First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 11242
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Renato Araujo Oliveira Filho <renatox@gmail.com>
Hardware:
OS:
Version:
Priority:
Severity:
Target Milestone:
Reporter: Renato Araujo Oliveira Filho <renatox@gmail.com>
Add CC:
CC:
Remove selected CCs
QA Contact:
URL:
Summary:
Status Whiteboard:
Keywords:

Attachment Type Creator Created Size Flags Actions
patch to update maemo code patch Renato Araujo Oliveira Filho 2007-10-20 22:23 36.73 KB none Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 11242 depends on: Show dependency tree
Show dependency graph
Bug 11242 blocks:

Additional Comments:







View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2007-10-20 22:21
update the current maemo port to new maemo sdk 4

------- Comment #1 From Renato Araujo Oliveira Filho 2007-10-20 22:23:00 -------
Created an attachment (id=4358) [details]
patch to update maemo code

------- Comment #2 From Ryan Pavlik 2007-10-21 03:18:07 -------
From my cursory examination of the patch, this removes pre-ITOS2008 support. 
As the current AbiWord on the N770 is rather buggy, is there a plan to
integrate both versions' support into a future revision of this patch?  As the
770 is still being sold as new, and there is no supported IT2008 environment
for it, I hesitate to ditch it completely.

------- Comment #3 From Hubert Figuière 2007-10-21 04:12:35 -------
that was my same perception. I'd love to see support for Maemo 3.0 (ie IT OS
2007) too. The patch looks nice, but really need to keep support for older
version. 

That would include adding detection of the version of the SDK in configure and
setting options accordingly.

Good work Renato

------- Comment #4 From Hubert Figuière 2007-10-21 04:13:04 -------
I forgot to add that I'd love to see that in the 2.6 branch ;-)

------- Comment #5 From Eduardo Lima (Etrunko) 2007-10-22 16:35:50 -------
(In reply to comment #2)
> From my cursory examination of the patch, this removes pre-ITOS2008 support. 
> As the current AbiWord on the N770 is rather buggy, is there a plan to
> integrate both versions' support into a future revision of this patch?  As the
> 770 is still being sold as new, and there is no supported IT2008 environment
> for it, I hesitate to ditch it completely.
> 

It does not remove support for versions pre-ITOS2008. The code in Abi SVN makes
use of HildonApp/HildonAppView and it was deprecated since ITOS2006. The new
code makes use of HildonProgram/HildonWindow is compatible with 770, N800 and
N810.

The only difference ITOS2008 introduces is the pkgconfig checking, as seen in
ac-helpers/abi-embedded.m4:

-         PKG_CHECK_MODULES(HILDON, hildon-libs hildon-fm dbus-1 libosso
libosso-gsf-1, [], [AC_MSG_ERROR([Hildon dependencies not satisfied.])])
+         PKG_CHECK_MODULES(HILDON, hildon-1 hildon-fm-2 dbus-1 libosso, [],
[AC_MSG_ERROR([Hildon dependencies not satisfied.])])

So, it is just a matter of keeping both checks to see if you're building for
ITOS2008 or ITOS2007/2006. Thre is no need to keep the HildonApp/AppView
obsolete code.

------- Comment #6 From Ryan Pavlik 2007-10-22 16:53:17 -------
Does that mean that the build system (in pkg/maemo/debian ) can be used to
build packages for 2006, 2007, and 2008 all from a patched source now?

Out of curiosity, why the new function in Unix-land?

------- Comment #7 From Eduardo Lima (Etrunko) 2007-10-22 17:04:29 -------
(In reply to comment #6)
> Does that mean that the build system (in pkg/maemo/debian ) can be used to
> build packages for 2006, 2007, and 2008 all from a patched source now?
> 

I can't confirm it 100% sure, but in theory yes. If you satisfy all
dependencies and do the right checks in abi-embedded.m4 its all good. :)

------- Comment #8 From Hubert Figuière 2007-10-25 18:00:52 -------
I'd say go ahead, commit the patch, and we'll fix the dependency check do build
on both.

I don't have a scratchbox here to install the Maemo SDK. I might have to do
that.

Off course this would have to be backported to 2.6 (let uwog to that) :-)

------- Comment #9 From Marc Maurer 2007-11-27 19:50:50 -------
Rock! Committed to head. Will port to 2.6 as well if it doesn't give me a
headache (it shouldn't)

------- Comment #10 From Marc Maurer 2007-11-27 20:04:50 -------
Committed to stable (2.6 as well).

First Last Prev Next    No search results available      Search page      Enter new bug