This is Bugzilla
View Bug Activity | Format For Printing | XML | Clone This Bug
Usually on touch driven interfaces you get two handles around the text selection so it can be manipulated after the initial selection, it'd be great to have this on Abiword too. GTK+ recently gained on master (to be soon in 3.6) internal support for its text widgets, although the helper object that allows this is kept private at the moment. I'm attaching a patch that incorporates this helper object in order to implement selection handles on the GTK+ frontend, those only appear when interacted with GdkDevices with source GDK_SOURCE_TOUCHSCREEN (available since gtk+ 3.4), as checked on ev_UnixMouse.cpp, so that code can be modified in order to test on any other device
Created an attachment (id=5617) [details] patch, implement touch handles for the GTK+ frontend
Some of the code should me moved to XP land, like the selection handles. I know it is not as easy as it sound, but this is part of what AbiWord is: cross-platform. Also, please make method "const" when appropriate.
Created an attachment (id=5619) [details] Updated patch This patch is updated to recent SVN, applies some fixes to handle GdkWindow creation, and fixes flickering selection when changed through the handles
(In reply to comment #2) > Some of the code should me moved to XP land, like the selection handles. I know > it is not as easy as it sound, but this is part of what AbiWord is: > cross-platform. Hey Hub, are you proposing that all of the handles' functionality should be in XP? The text handles use windowing resources, they aren't just rendered atop, There are also theming/a11y considerations in mind, as this would have abiword display the same handles than regular GTK+ applications. This is mostly why I went for an empty texthandle stub in xp code and a separate gtk+ implementation, msevior also seemed to hint that path: http://abisource.com/mailinglists/abiword-dev/2012/Jul/0049.html > > Also, please make method "const" when appropriate. > I'll double check those
Created an attachment (id=5628) [details] updated patch This patch contains some accumulated fixes, and checks the ABI_TEST_TOUCH envvar so the changes can be tested without a touchscreen, Adwaita from gnome 3.6 will be needed in order to get proper appearance for the touch handles
not sure how we can make sure we have the theme at run time. Applied and reworked this patch locally. Will push it soon.
in trunk@32639 and trunk@32640
(From update of attachment 5628 [details]) applied with changes.
Crash regression fixed trunk@32670